Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed TypeMsg constants #2478

Merged
merged 6 commits into from
Oct 7, 2022
Merged

Removed TypeMsg constants #2478

merged 6 commits into from
Oct 7, 2022

Conversation

alizahidraja
Copy link
Contributor

@alizahidraja alizahidraja commented Oct 5, 2022 •
edited
Loading

Description

closes: #2434

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

damiannolan
damiannolan reviewed Oct 6, 2022
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @alizahidraja!

Left one comment regarding portID arg in 04-channel tests.

modules/core/04-channel/keeper/keeper_test.go Outdated Show resolved Hide resolved
colin-axner
colin-axner approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alizahidraja! Nice to keep the code clean 🧹

damiannolan
damiannolan approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🚀

@alizahidraja
Copy link
Contributor Author

Need help, can't figure out why that one test is failing

Check Markdown links / markdown-link-check (pull_request) Failing

@damiannolan
Copy link
Member

Need help, can't figure out why that one test is failing

Check Markdown links / markdown-link-check (pull_request) Failing

All good. Looks like a dead link in some older migration docs: #2488

@crodriguezvega crodriguezvega merged commit 126b6f3 into cosmos:main Oct 7, 2022
@crodriguezvega crodriguezvega mentioned this pull request Jun 21, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@seantking seantking Awaiting requested review from seantking

@charleenfei charleenfei Awaiting requested review from charleenfei

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@chatton chatton Awaiting requested review from chatton chatton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all "TypeMsg.." constants
4 participants
@alizahidraja @damiannolan @colin-axner @crodriguezvega